[0002285] Implement feature with extra resources near mines #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Nordsoft91
commented
May 19, 2022
Nordsoft91
commented
- Fix issue with town entry blocked by monster
- Implemented extra resources nearby mines on random map
This comment was marked as resolved.
This comment was marked as resolved.
DjWarmonger
reviewed
May 20, 2022
DjWarmonger
reviewed
May 20, 2022
DjWarmonger
reviewed
May 20, 2022
Nordsoft91
changed the title
nullkiller
reviewed
May 21, 2022
nullkiller
reviewed
May 21, 2022
lib/rmg/CRmgTemplateZone.cpp
Outdated
Comment on lines
1313
to
1317
| auto mine = (CGMine*) VLC->objtypeh->getHandlerFor(Obj::MINE, res)->create(ObjectTemplate()); | ||
| tempmines.emplace_back(mine); | ||
| mine->producedResource = res; | ||
| mine->tempOwner = PlayerColor::NEUTRAL; | ||
| mine->producedQuantity = mine->defaultResProduction(); |
There was a problem hiding this comment.
This section of code is repeated a few times. I suggest to introduce a factory method to create a mine by res type and set these default settings and afterwards we will only need to call addRequiredObject/addCloseObject
There was a problem hiding this comment.
Thanks for advise! I decided to change a bit this code but keep the idea to remove duplications
nullkiller
reviewed
May 21, 2022
nullkiller
reviewed
May 21, 2022
nullkiller
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.