Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more setup, and the addition of inverse_of's in models #1

Merged
merged 7 commits into from Jun 6, 2016

Conversation

Projects
None yet
2 participants
@trodrigu
Copy link
Contributor

commented Jun 3, 2016

This pull request adds useful gems database_cleaner and should matchers. It also add the inverse_of to a few of the models to allow the create of intermediate models on one call to create.

@vcolavin

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2016

Looks good, and it runs on my machine! I appreciate the help very much; I hadn't heard about inverse_of before, and that combined with fixing that pluralization typo did the trick!

I generally prefer let over let! so I will change it after the merge, but good work on the tests too!

Thanks again 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍

@vcolavin vcolavin merged commit 22f0730 into vcolavin:master Jun 6, 2016

@vcolavin

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2016

Ah now I see why you did that.

@trodrigu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2016

No problem 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.