Update unhandled request error so it mentions the debug_logger option. #188

Closed
myronmarston opened this Issue Aug 2, 2012 · 4 comments

2 participants

@myronmarston
VCR member

This'll help point users towards this option as a way to figure out why the request is unhandled for cases where this is unexpected behavior.

@Jacobkg
VCR member

Not sure how you wanted to format this, but I was thinking something like: (new part is bolded)

Under the current configuration VCR can not find a suitable HTTP interaction
to replay and is prevented from recording new requests. There are a few ways
you can deal with this:

@myronmarston
VCR member

That looks pretty good, although I wonder if it would be better to put it first so that it's less likely end users will over look it in the long error message? If you put it first, you may want to phrase it like "If you're surprised VCR is raising this error and want insight about how VCR attempted to handle the request, you can use the debug_logger option to log more details"

Thoughts?

Regardless, feel free to take a stab at this :).

@Jacobkg Jacobkg added a commit that referenced this issue Aug 15, 2012
@Jacobkg Jacobkg Fix for #188. Add mention of debug logging configuration option to un…
…handled request error message. Also added it to the no_cassette.feature.
d72b7b7
@Jacobkg
VCR member

I took a stab at it. Wasn't sure about adding that bit to Relish or not, so feel free to remove it.

@myronmarston myronmarston added a commit that referenced this issue Aug 15, 2012
@Jacobkg Jacobkg Fix for #188. Add mention of debug logging configuration option to un…
…handled request error message. Also added it to the no_cassette.feature.
a683b67
@myronmarston
VCR member

Looks great. I cherry-picked this over to master (and removed some trailing whitespace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment