Typhoeus 0.4.2 is out and works fine with VCR #184

Merged
merged 1 commit into from Jul 25, 2012

Conversation

Projects
None yet
2 participants
Contributor

JonathanTron commented Jul 25, 2012

I'm using VCR with Typhoeus 0.4.2 in nmy test suites and it works fine.

@myronmarston myronmarston commented on an outdated diff Jul 25, 2012

lib/vcr/library_hooks/typhoeus.rb
@@ -2,7 +2,7 @@
require 'vcr/request_handler'
require 'typhoeus'
-VCR::VersionChecker.new('Typhoeus', Typhoeus::VERSION, '0.3.2', '0.3').check_version!
+VCR::VersionChecker.new('Typhoeus', Typhoeus::VERSION, '0.3.2', '0.4.2').check_version!
@myronmarston

myronmarston Jul 25, 2012

Owner

I think we should be passing '0.4' to the version checker, not '0.4.2'. That argument is meant to be the max warning-free minor version. I generally assume that patch releases won't break compatibility but, for projects that have not adopted SemVer, minor releases might--so I'd want VCR to not print a warning when 0.4.3, 0.4.4, etc come out, but I do want it to print a warning for 0.5 since that will potentially break compatibility and I obviously don't know for sure if it'll automatically work.

Owner

myronmarston commented Jul 25, 2012

Thanks! Did you run the VCR tests to conform that they all pass against Typhoeus 0.4.2 as well?

Contributor

JonathanTron commented Jul 25, 2012

I checked the spec and feature and they pass with Typhoeus 0.4.2.
I sent another commit, loosening the typhoeus check in both the version checker and the gemspec.
But now that I'm re-reading your comment, I should probably have set the version in the gemspec to >= 0.3.2, so that the version checker is triggered when used with future version, but we do not prevent installation of the gem.

What do you think?

Owner

myronmarston commented Jul 25, 2012

The version in the gemspec just constrains what version bundler installs for VCR development--it doesn't affect end users of VCR at all. I think it's fine how you've done it.

Can you squash these into a single commit? Then I'll be glad to merge it. Thanks!

Contributor

JonathanTron commented Jul 25, 2012

Here's the squashed commit.

@myronmarston myronmarston added a commit that referenced this pull request Jul 25, 2012

@myronmarston myronmarston Merge pull request #184 from JonathanTron/patch-1
Typhoeus 0.4.2 is out and works fine with VCR
1fac6cf

@myronmarston myronmarston merged commit 1fac6cf into vcr:master Jul 25, 2012

Owner

myronmarston commented Jul 25, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment