Join GitHub today
PR related to #403 / Thread safety, actors #404
This contains the changes for #403 - particularly the use of celluloid to avoid concurrency problems. There remain some issues (3 failing specs under rbx/mri) - I spread FIXME-marks as reminders:
@myronmarston We could discuss/resolve the open questions in a remote session or asynchronously, just as you prefer.
Thanks for opening this...and sorry for the radio silence. Finding time to maintain VCR is hard for me with my responsibilities to RSpec :(.
BTW, ignore the houndci comments. I don't remember enabling that but apparently I did. I just disabled it. It's noise at this point.
This is definitely a problem...at least, if we want to release this in a 2.x release. VCR follows SemVer, which means we can't cut a 2.x release that breaks compatibility with 1.8.7. I see two basic paths we can take here:
I'm kind leaning towards door number 2 personally...what do you think?
I don't have time to look more into this at the moment, sadly...but I do plan to at a later time.
BTW, if you want to discuss this stuff in real time, ping me on IRC. I hang out in the RSpec room on freenode most days.
I think making the celluloid-support optional is perfectly doable. Concerning the thread-cleanup: right, celluloid spawns some household-threads (i.e. for supervision) - so killing threads in between will cause havoc. I'll push some commits that make the celluloid dependency an opt-in during the next days.