Allow rbx-2 to fail without breaking Travis build. #625

Merged
merged 1 commit into from Dec 9, 2016

Projects

None yet

2 participants

@ecnalyr
Member
ecnalyr commented Dec 7, 2016 edited
  • The rbx-2 buils fails most of the time on Travis, but not because of a problem with VCR’s codebase.
  • Precedence? Capistrano recently made the same change: capistrano/capistrano#1784

I feel like the red Travis builds are making it not fun to contribute to this project, trying to get our builds green.

This can be undone once rvm releases a new version that includes the fix merged into master that was discussed here: rvm/rvm#3617

@ecnalyr ecnalyr Allow rbx-2 to fail without breaking Travis build.
- The rbx-2 buils fails most of the time on Travis, but not because of a problem with VCR’s codebase.
- Precedence?  Capistrano recently made the same change: capistrano/capistrano#1784
e9f550d
@mcfiredrill
Collaborator

Actually I'm pretty sure this is what broke the rbx-2 build:
#619

I could try reverting it, but honestly I don't really mind allowing the failure either as this is just kind of another obstacle to contributing in my mind. :\

@ecnalyr
Member
ecnalyr commented Dec 8, 2016 edited

Nah, the changes in #619 pr did not cause this problem.

Lots of people are having this issue with rbx-2, or any version of Rubinius, and Travis right now (for a few months now, actually. . . e.g. vmg/redcarpet#580).

@mcfiredrill
Collaborator

@ecnalyr Thanks for letting me know. I will merge this for now, at least we will have some green builds going forward.

@mcfiredrill mcfiredrill merged commit 3fe3166 into vcr:master Dec 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment