Skip to content

Drop Python 3.9 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 1, 2025
Merged

Drop Python 3.9 #497

merged 11 commits into from
Nov 1, 2025

Conversation

@tony
Copy link
Member

@tony tony commented Nov 1, 2025 •
edited
Loading

@codecov
Copy link

codecov bot commented Nov 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.90%. Comparing base (633127d) to head (1a8b6d3).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/libvcs/sync/git.py 66.66% 4 Missing ⚠️
src/libvcs/_internal/query_list.py 25.00% 3 Missing ⚠️
src/libvcs/_internal/run.py 0.00% 3 Missing ⚠️
src/libvcs/cmd/svn.py 0.00% 3 Missing ⚠️
src/libvcs/cmd/git.py 0.00% 1 Missing ⚠️
src/libvcs/cmd/hg.py 0.00% 1 Missing ⚠️
src/libvcs/pytest_plugin.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   42.88%   42.90%   +0.01%     
==========================================
  Files          38       38              
  Lines        3628     3627       -1     
  Branches      795      794       -1     
==========================================
  Hits         1556     1556              
  Misses       1718     1718              
+ Partials      354      353       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tony added 11 commits November 1, 2025 10:25
@tony
ci(tests) Drop Python 3.9
5e5fa5b 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
pyproject(requires-python) 3.9 -> 3.10 minimum
b0f34aa 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
pyproject(trove classifiers) Drop Python 3.9
a88bdb9 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
py(deps) Bump for 3.10+ via uv sync --all-extras --dev --upgrade
a14de4e
@tony
pyproject(tool.ruff) Bump target-version py39 -> py310
0a77bf6 
See also:
- https://docs.astral.sh/ruff/settings/#target-version
- Python 3.9 EOL:
  - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
  - https://peps.python.org/pep-0596/
@tony
pyproject(tool.mypy) Bump python_version 3.9 -> 3.10
ece1068 
See also:
- https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version
- Python 3.9 EOL:
  - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
  - https://peps.python.org/pep-0596/
@tony
docs(README) Python minimum 3.9 -> 3.10
260d51e 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
docs(CHANGES) Note dropping of Python 3.9
a586b2f
@tony
chore(ruff): Autofixes for ruff with Python 3.10+
5ab8bf5 
uv run ruff check . --fix --show-fixes

Fixed 21 errors:
- src/libvcs/_internal/run.py:
    2 × UP007 (non-pep604-annotation-union)
    1 × UP035 (deprecated-import)
    1 × UP045 (non-pep604-annotation-optional)
- src/libvcs/_internal/shortcuts.py:
    1 × UP035 (deprecated-import)
- src/libvcs/_internal/subprocess.py:
    4 × UP007 (non-pep604-annotation-union)
    1 × UP035 (deprecated-import)
- src/libvcs/_internal/types.py:
    2 × UP007 (non-pep604-annotation-union)
    1 × UP035 (deprecated-import)
- src/libvcs/pytest_plugin.py:
    1 × UP035 (deprecated-import)
    1 × UP045 (non-pep604-annotation-optional)
- src/libvcs/sync/constants.py:
    1 × UP007 (non-pep604-annotation-union)
- src/libvcs/url/registry.py:
    1 × UP007 (non-pep604-annotation-union)
    1 × UP035 (deprecated-import)
- tests/url/test_registry.py:
    1 × UP007 (non-pep604-annotation-union)
    1 × I001 (unsorted-imports)
    1 × UP035 (deprecated-import)

Found 30 errors (21 fixed, 9 remaining).
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
@tony
refactor(mypy): Adopt Python 3.10 typing idioms
9008ed0 
- replace remaining Optional/Union patterns with PEP 604 unions aligned to the new baseline
- remove outdated version blocks for Python 3.10 (now minimum)
- add explicit strict=False to zip-based operations to satisfy Ruff B905

uv run ruff check . --fix --show-fixes
uv run ruff format .
uv run mypy
uv run py.test
@tony
chore(ruff): Unsafe autofixes for ruff with Python 3.10+
1a8b6d3 
uv run ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes

Fixed 11 errors:
- src/libvcs/_internal/query_list.py:
    2 × G004 (logging-f-string)
- src/libvcs/sync/git.py:
    9 × G004 (logging-f-string)

Found 1040 errors.
1029 files left unchanged
@tony tony merged commit d19157d into master Nov 1, 2025
8 checks passed
@tony tony deleted the drop-python-3.9 branch November 1, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony