New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ylibvcs.git: Fix unbound local variable 'tag_sha' error #11

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
3 participants
@jcfr
Collaborator

jcfr commented Jun 22, 2016

This commit fixes error like this one:

Traceback (most recent call last):
  File "./extensions-index-checkout.py", line 150, in <module>
    duration, result = timecall(repo.update_repo)()
  File "./extensions-index-checkout.py", line 53, in wrapper
    result = method(*args, **kwargs)
  File "/home/jcfr/Projects/sandbox/libvcs/libvcs/git.py", line 198, in update_repo
    self.debug("tag_sha: %s" % tag_sha)

UnboundLocalError: local variable 'tag_sha' referenced before assignment
libvcs.git: Fix unbound local variable 'tag_sha' error
This commit fixes error like this one:

```
Traceback (most recent call last):
  File "./extensions-index-checkout.py", line 150, in <module>
    duration, result = timecall(repo.update_repo)()
  File "./extensions-index-checkout.py", line 53, in wrapper
    result = method(*args, **kwargs)
  File "/home/jcfr/Projects/sandbox/libvcs/libvcs/git.py", line 198, in update_repo
    self.debug("tag_sha: %s" % tag_sha)

UnboundLocalError: local variable 'tag_sha' referenced before assignment
```
@codecov-io

This comment has been minimized.

codecov-io commented Jun 22, 2016

Current coverage is 65.15%

Merging #11 into master will decrease coverage by 0.13%

@@             master        #11   diff @@
==========================================
  Files             7          7          
  Lines           484        485     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            316        316          
- Misses          168        169     +1   
  Partials          0          0          

Powered by Codecov. Last updated by 7f8c6a8...9f9c24f

@tony

This comment has been minimized.

Member

tony commented Jun 22, 2016

We need test coverage there bad

@tony tony merged commit be16f32 into vcs-python:master Jun 22, 2016

1 of 3 checks passed

codecov/patch 0.00% of diff hit (target 65.28%)
Details
codecov/project 65.15% (-0.14%) compared to 7f8c6a8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment