From bf886bb435cc90400b7b06863176488db856956b Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 25 Jun 2022 05:54:45 -0500 Subject: [PATCH 1/2] chore(git): Remove uses_netloc for git+ssh, already in cpython See also: - https://github.com/python/cpython/commit/ead169d3114ed0f1041b5b59ca20293449608c50 - https://bugs.python.org/issue8657 or https://github.com/python/cpython/issues/52903#issuecomment-1093501859 --- libvcs/projects/git.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvcs/projects/git.py b/libvcs/projects/git.py index c991a7b3a..5ff062e6f 100644 --- a/libvcs/projects/git.py +++ b/libvcs/projects/git.py @@ -157,7 +157,7 @@ def convert_pip_url(pip_url: str) -> VCSLocation: class GitProject(BaseProject): bin_name = "git" - schemes = ("git", "git+http", "git+https", "git+ssh", "git+git", "git+file") + schemes = ("git", "git+http", "git+https", "git+git", "git+file") _remotes: GitProjectRemoteDict def __init__( From 2db34eabcd4281d2d8ea0b018f8aecb7f84e1529 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 25 Jun 2022 06:10:28 -0500 Subject: [PATCH 2/2] docs(CHANGES): Note removal of redundant netloc --- CHANGES | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CHANGES b/CHANGES index c807aecae..46eeb253f 100644 --- a/CHANGES +++ b/CHANGES @@ -42,6 +42,18 @@ $ pip install --user --upgrade --pre libvcs _Backport from 0.13.3_ +### Cleanup + +- :{issue}`378` Remove duplicate `uses_netloc` scheme for `git+ssh` (this was in cpython since 2.7 / + 3.1 [^git+ssh][^python:bugs:8657]) + +[^git+ssh]: [python/cpython@ead169d] + +[python/cpython@ead169d]: + https://github.com/python/cpython/commit/ead169d3114ed0f1041b5b59ca20293449608c50 + +[^python:bugs:8657]: + ## libvcs 0.13.6 (2022-06-18) ### Development