Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Move to XDG_CONFIG_HOME #367

Merged
merged 2 commits into from
Apr 10, 2022
Merged

refactor!: Move to XDG_CONFIG_HOME #367

merged 2 commits into from
Apr 10, 2022

Conversation

tony
Copy link
Member

@tony tony commented Apr 9, 2022

  • New default config dir is XDG_CONFIG_HOME, Usually ~/.config/vcspull
  • Custom config via VCSPULL_CONFIGDIR
  • Legacy support until deprecated via LEGACY_CONFIG_DIR (subject to
    being removed in future releases)

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #367 (6ebe725) into master (2325d0a) will increase coverage by 0.68%.
The diff coverage is 98.11%.

❗ Current head 6ebe725 differs from pull request most recent head 057d443. Consider uploading reports for the commit 057d443 to get more accurate results

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   86.62%   87.31%   +0.68%     
==========================================
  Files          12       13       +1     
  Lines         628      670      +42     
==========================================
+ Hits          544      585      +41     
- Misses         84       85       +1     
Impacted Files Coverage Δ
tests/test_config_file.py 97.14% <ø> (ø)
vcspull/config.py 96.00% <83.33%> (-0.70%) ⬇️
tests/conftest.py 94.66% <100.00%> (+0.72%) ⬆️
tests/test_utils.py 100.00% <100.00%> (ø)
vcspull/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2325d0a...057d443. Read the comment docs.

@tony tony force-pushed the xdg-default branch 3 times, most recently from fa22f45 to 6ebe725 Compare April 10, 2022 00:40
- New default config dir is XDG_CONFIG_HOME, Usually ~/.config/vcspull
- Custom config via VCSPULL_CONFIGDIR
- Legacy support until deprecated via LEGACY_CONFIG_DIR (subject to
  being removed in future releases)
tony added a commit that referenced this pull request Apr 10, 2022
@tony tony merged commit ff2923c into master Apr 10, 2022
@tony tony deleted the xdg-default branch April 10, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant