Skip to content

ci(mypy): Turn on mypy --strict #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 31, 2022
Merged

ci(mypy): Turn on mypy --strict #386

merged 5 commits into from
Dec 31, 2022

Conversation

@tony tony force-pushed the strict-mypy branch 3 times, most recently from b5258c3 to e7f8c0f Compare September 26, 2022 02:33
@tony tony force-pushed the master branch 2 times, most recently from 54b2d28 to b9c0aa1 Compare October 1, 2022 16:00
@tony tony force-pushed the strict-mypy branch 2 times, most recently from 81d3d79 to 773994c Compare October 23, 2022 17:34
@tony tony force-pushed the strict-mypy branch 4 times, most recently from 6fa928f to ffbe335 Compare December 29, 2022 15:40
@tony tony force-pushed the strict-mypy branch 3 times, most recently from caaadf6 to 5c075a3 Compare December 31, 2022 13:55
@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #386 (e8f81df) into master (f7f4d96) will decrease coverage by 1.36%.
The diff coverage is 78.10%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   85.37%   84.00%   -1.37%     
==========================================
  Files          16       17       +1     
  Lines         889      938      +49     
  Branches      157      168      +11     
==========================================
+ Hits          759      788      +29     
- Misses         89      100      +11     
- Partials       41       50       +9     
Impacted Files Coverage Δ
tests/test_cli.py 88.23% <ø> (ø)
src/vcspull/validator.py 40.00% <40.00%> (ø)
src/vcspull/log.py 68.42% <46.15%> (ø)
src/vcspull/cli/sync.py 72.09% <61.90%> (-1.25%) ⬇️
conftest.py 78.04% <83.33%> (ø)
tests/test_config.py 96.96% <90.90%> (-3.04%) ⬇️
tests/test_sync.py 90.27% <92.30%> (-1.03%) ⬇️
src/vcspull/_internal/config_reader.py 94.44% <100.00%> (ø)
src/vcspull/config.py 84.67% <100.00%> (-1.36%) ⬇️
src/vcspull/types.py 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 862a460 into master Dec 31, 2022
@tony tony deleted the strict-mypy branch December 31, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict mypy annotations
1 participant