vcspull add - even more bug fixes
#483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: vcspull add run from the workspace root mislabels the workspace as './'. what: - add xfail capturing that Workspace root should contract to the tilde path
why: Running vcspull add from the workspace root should still display the tilde path instead of './'. what: - allow workspace_root_label callers to opt out of the cwd short-circuit - pass preserve_cwd_label only when users explicitly request './' or for legacy name/url flows
why: The regression test now verifies shows '~/study/python/' even when run from that workspace. what: - remove xfail and assert both log and config store the tilde-labelled workspace
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 79.04% 79.09% +0.04%
==========================================
Files 13 13
Lines 1785 1789 +4
Branches 381 382 +1
==========================================
+ Hits 1411 1415 +4
Misses 235 235
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tony
added a commit
that referenced
this pull request
Nov 3, 2025
why: Document that path-first adds now keep tilde workspace labels even when run from the workspace root. what: - add bug-fix entry under v1.46.x referencing PR #483
why: Document that path-first adds now keep tilde workspace labels even when run from the workspace root. what: - add bug-fix entry under v1.46.x referencing PR #483
tony
force-pushed
the
vcspull-add-bug-pt-3
branch
from
b86f4b1 to
9cf8d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier:
vcspull add: Usability overhaul and tests #481vcspull add: Fix more issues #482Changes
Fix:
vcspull addkeeps tilde workspace labels (#483)why: Path-first adds run from inside a workspace were logging './' instead of the
expected '~/…/'.
what:
workspace_root_labelcallers to bypass the cwd short-circuit--workspace ./Regression coverage: workspace label from root
why: Prevent future regressions in path-first adds when invoked from the workspace
root.
what:
Verification