New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to build as a .NET Core 2.1 console tool package #33

Merged
merged 1 commit into from Jul 2, 2018

Conversation

2 participants
@natemcmaster
Contributor

natemcmaster commented Jul 1, 2018

  • Convert target framework to netcoreapp2.1
  • Add packaging details
  • Return E_PLATFORMNOTSUPPORTED if the tool is run on Linux/macOS

I see you already started similar work. Here's how I would have done it.

Update project to build as a .NET Core console tool package
* Convert target framework to netcoreapp2.1
* Add packaging details
* Return E_PLATFORMNOTSUPPORTED if the tool is run on Linux/macOS
@vcsjones

This comment has been minimized.

Owner

vcsjones commented Jul 2, 2018

Thank you! I think I'll replace my PR with this one.

@vcsjones vcsjones referenced this pull request Jul 2, 2018

Closed

WIP - Move to .NET Core 2.1 #32

@vcsjones vcsjones merged commit 238c617 into vcsjones:master Jul 2, 2018

@vcsjones vcsjones referenced this pull request Jul 2, 2018

Closed

NetCoreApp 2.0 #30

@natemcmaster natemcmaster deleted the natemcmaster:global-tool branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment