Work on solution for paths of claims #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That 404s FWIW. https://vcstuff.github.io/sd-jwt-vc-types/danielfett/fix-claims/draft-fett-oauth-sd-jwt-vc-types.html should work. I think I like this approach though. |
bc-pi
reviewed
Feb 15, 2024
bc-pi
reviewed
Feb 15, 2024
bc-pi
reviewed
Feb 15, 2024
bc-pi
reviewed
Feb 15, 2024
danielfett
commented
Feb 19, 2024
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
|
I've played around with some of the options and I was surprised how well the array of strings seemed to work when traversing a nested struct (fits quite nicely with a stack remembering the parent names). The only thing that just feels wrong to me is the null to signal all elements of an array but not sure what the cleanest/best option would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
click here for rendered preview of PR