Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal/log/logger to match the test template #371

Merged
merged 3 commits into from May 13, 2020
Merged

Fix internal/log/logger to match the test template #371

merged 3 commits into from May 13, 2020

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented May 11, 2020 •
edited

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I fixed internal/log/logger to match the test template.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 11, 2020 •
edited

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan

     fix: to match the test template

     fix: goleak bug. t -> tt

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update 0155d71 ... f665e33. Read the comment docs.

@hlts2 hlts2 requested review from kmrmt and kevindiu May 11, 2020 07:28
@hlts2
Copy link
Contributor Author

hlts2 commented May 11, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_logger_test

@hlts2 hlts2 changed the title fix: to match the test template internal/log/logger: fix to match the test template May 11, 2020
@hlts2 hlts2 changed the title internal/log/logger: fix to match the test template Fix internal/log/logger to match the test template May 11, 2020
@kevindiu
Copy link
Contributor

LGTM

@hlts2
Copy link
Contributor Author

hlts2 commented May 12, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_logger_test

@vdaas-ci vdaas-ci force-pushed the test/internal/log_logger_test branch from 776b394 to 2b08485 Compare May 12, 2020 02:10
@codecov
Copy link

codecov bot commented May 12, 2020 •
edited

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #371   +/-   ##
======================================
  Coverage    7.90%   7.90%           
======================================
  Files         346     346           
  Lines       17804   17804           
======================================
  Hits         1408    1408           
  Misses      16215   16215           
  Partials      181     181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcabeaa...f665e33. Read the comment docs.

vankichi
vankichi previously approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/format

@vankichi vankichi requested review from kpango and rinx May 12, 2020 08:44
@vankichi
Copy link
Contributor

@kpango @rinx
Could you please review, if you have time?

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

rinx
rinx reviewed May 12, 2020
View reviewed changes
internal/log/logger/type_test.go Outdated Show resolved Hide resolved
internal/log/logger/type_test.go Outdated Show resolved Hide resolved
@hlts2
Copy link
Contributor Author

hlts2 commented May 13, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_logger_test

@vdaas-ci vdaas-ci force-pushed the test/internal/log_logger_test branch from 2b08485 to 2fb6840 Compare May 13, 2020 01:34
vankichi
vankichi previously approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/format

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@kpango
Copy link
Collaborator

kpango commented May 13, 2020

/rebase
/format

@kpango kpango closed this May 13, 2020
@kpango kpango reopened this May 13, 2020
@kpango
Copy link
Collaborator

kpango commented May 13, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: test/internal/log_logger_test

hlts2 and others added 3 commits May 13, 2020 09:08
@hlts2 @actions-user
fix: to match the test template
0155d71 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: goleak bug. t -> tt
58fc322 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci @actions-user
🤖 Update license headers and formatting go codes
f665e33 
Signed-off-by: vdaas-ci <ci@vdaas.org>
@vdaas-ci vdaas-ci force-pushed the test/internal/log_logger_test branch from a5accbd to f665e33 Compare May 13, 2020 09:08
@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: test/internal/log_logger_test

@kpango kpango merged commit 78486eb into master May 13, 2020
@kpango kpango deleted the test/internal/log_logger_test branch May 13, 2020 09:10
@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinx rinx rinx left review comments

@vankichi vankichi vankichi left review comments

@kmrmt kmrmt Awaiting requested review from kmrmt

@kevindiu kevindiu Awaiting requested review from kevindiu

@kpango kpango Awaiting requested review from kpango

Assignees
No one assigned
Labels
area/internal priority/low size/L status/author-review team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hlts2 @vdaas-ci @kevindiu @vankichi @kpango @rinx