New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album cover in ✧Current Track view #181

Closed
w888881 opened this Issue Mar 16, 2017 · 17 comments

Comments

2 participants
@w888881

w888881 commented Mar 16, 2017

Hey Vincent,
This workflow is awesome, thanks for all the work!
Can you please add an album cover also in ✧Current Track view?

Thanks!

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 16, 2017

Owner
Owner

vdesabou commented Mar 16, 2017

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 16, 2017

It works for songs from my playlists, but not when I search for something new or e.g. songs from Your Daily Mix.

w888881 commented Mar 16, 2017

It works for songs from my playlists, but not when I search for something new or e.g. songs from Your Daily Mix.

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 16, 2017

I found this happens only with 'Now Playing Notifications' turned off.

w888881 commented Mar 16, 2017

I found this happens only with 'Now Playing Notifications' turned off.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 20, 2017

Owner

It works for songs from my playlists, but not when I search for something new or e.g. songs from Your Daily Mix.

That's expected: if the current track is part of the library, the artwork is shown, but if the current track is not part of your library, then a generic artwork is shown:

screenshot 2017-03-20 at 10 32 09

The reason is that if I want to display an artwork, we have to download it, and it will add a few seconds delay for Current Track, which is very unpleasant for the user.

Owner

vdesabou commented Mar 20, 2017

It works for songs from my playlists, but not when I search for something new or e.g. songs from Your Daily Mix.

That's expected: if the current track is part of the library, the artwork is shown, but if the current track is not part of your library, then a generic artwork is shown:

screenshot 2017-03-20 at 10 32 09

The reason is that if I want to display an artwork, we have to download it, and it will add a few seconds delay for Current Track, which is very unpleasant for the user.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 20, 2017

Owner

I found this happens only with 'Now Playing Notifications' turned off.

I'm not sure about that.. I tried to reproduce but there is no link with that option

Owner

vdesabou commented Mar 20, 2017

I found this happens only with 'Now Playing Notifications' turned off.

I'm not sure about that.. I tried to reproduce but there is no link with that option

@vdesabou vdesabou self-assigned this Mar 20, 2017

@vdesabou vdesabou added the question label Mar 20, 2017

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 20, 2017

Of course we don't want to have any delay when loading a next song.
I noticed currently, an artwork is downloaded for 'Now Playing' notification (Mac's Notification Center) which seems to be async request. However, when I disable the option, an artwork is never downloaded. How about making async request to download an artwork if this is disabled?
image

w888881 commented Mar 20, 2017

Of course we don't want to have any delay when loading a next song.
I noticed currently, an artwork is downloaded for 'Now Playing' notification (Mac's Notification Center) which seems to be async request. However, when I disable the option, an artwork is never downloaded. How about making async request to download an artwork if this is disabled?
image

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 20, 2017

Owner

I don't understand..

If you disable Now Playing notifications, you don't get notification, so where is the artwork missing in this case ??

Owner

vdesabou commented Mar 20, 2017

I don't understand..

If you disable Now Playing notifications, you don't get notification, so where is the artwork missing in this case ??

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 20, 2017

The only concern I have is with ✧Current Track view as per your screenshot.
If I disable Now Playing notification and go to 'Current Track' view while a song is playing it doesn't display an artwork.
With Now Playing notification enabled, it displays an artwork on the notification itself, but also in 'Current Track'.

w888881 commented Mar 20, 2017

The only concern I have is with ✧Current Track view as per your screenshot.
If I disable Now Playing notification and go to 'Current Track' view while a song is playing it doesn't display an artwork.
With Now Playing notification enabled, it displays an artwork on the notification itself, but also in 'Current Track'.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 20, 2017

Owner

allright, I see the link now :)

So what happens is:

-Track is played
-Now Playing notification download the artwork
-When you invoke Current Track, as the artwork has been already downloaded, it is displayed

That's why if you disable Now Playing notifications, the artwork is not downloaded and Current Track will not display album cover.

There is no way to do async download with Current Track. We need to pass to Alfred an image, so it has to be downloaded beforehand, which will take a few seconds and slow down the workflow

Owner

vdesabou commented Mar 20, 2017

allright, I see the link now :)

So what happens is:

-Track is played
-Now Playing notification download the artwork
-When you invoke Current Track, as the artwork has been already downloaded, it is displayed

That's why if you disable Now Playing notifications, the artwork is not downloaded and Current Track will not display album cover.

There is no way to do async download with Current Track. We need to pass to Alfred an image, so it has to be downloaded beforehand, which will take a few seconds and slow down the workflow

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 20, 2017

I think it would be enough to download when a song is starting - instead of 'Now playing notification download the artwork' is it possible to do this that way:

  • Track is played
  • a) if Now Playing Notification is enabled: download the artwork and display the notification [NO CHANGE]
    b) if Now Playing Notification is disabled: download the artwork but don't display the notification
  • When you invoke Current Track, as the artwork has been already downloaded, it is displayed.

w888881 commented Mar 20, 2017

I think it would be enough to download when a song is starting - instead of 'Now playing notification download the artwork' is it possible to do this that way:

  • Track is played
  • a) if Now Playing Notification is enabled: download the artwork and display the notification [NO CHANGE]
    b) if Now Playing Notification is disabled: download the artwork but don't display the notification
  • When you invoke Current Track, as the artwork has been already downloaded, it is displayed.
@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 20, 2017

Owner

I get your point, it makes sense. Will see how I can get it done

Owner

vdesabou commented Mar 20, 2017

I get your point, it makes sense. Will see how I can get it done

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 20, 2017

Awesome. Thanks!

w888881 commented Mar 20, 2017

Awesome. Thanks!

@vdesabou vdesabou added enhancement and removed question labels Mar 21, 2017

@vdesabou vdesabou added this to the 7.1 milestone Mar 22, 2017

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 22, 2017

Owner

Can you download and install this beta https://transfer.sh/BFNUv/spotifyminiplayer-beta.alfredworkflow

Let me know if everything is working as you expect.

Owner

vdesabou commented Mar 22, 2017

Can you download and install this beta https://transfer.sh/BFNUv/spotifyminiplayer-beta.alfredworkflow

Let me know if everything is working as you expect.

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 22, 2017

It works great! Thank you!

w888881 commented Mar 22, 2017

It works great! Thank you!

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 22, 2017

Owner

@w888881

good !

While I have you here...The beta includes also http://alfred-spotify-mini-player.com/articles/recent-tracks/

Would you mind testing it as well?

Owner

vdesabou commented Mar 22, 2017

@w888881

good !

While I have you here...The beta includes also http://alfred-spotify-mini-player.com/articles/recent-tracks/

Would you mind testing it as well?

@w888881

This comment has been minimized.

Show comment
Hide comment
@w888881

w888881 Mar 22, 2017

  1. when I selected the 'Your Recent track' option it forced me to re-authenticate the app to use the function
  2. if you select a song from Recent Tracks and it completes, there's an issue with the native app - the progress bar does not reset and the play/pause button still displays 'Pause' icon. If see this is also the case if you play the last song from 'Local Files' within the app, but not for 'Songs'. No worries, I'll report this bug to Spotify dev team :)

Thanks!

w888881 commented Mar 22, 2017

  1. when I selected the 'Your Recent track' option it forced me to re-authenticate the app to use the function
  2. if you select a song from Recent Tracks and it completes, there's an issue with the native app - the progress bar does not reset and the play/pause button still displays 'Pause' icon. If see this is also the case if you play the last song from 'Local Files' within the app, but not for 'Songs'. No worries, I'll report this bug to Spotify dev team :)

Thanks!

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Mar 23, 2017

Owner
  1. yes it is expected
  2. I can't reproduce this, but as I understand it, it is out of scope of my workflow

Thanks

Owner

vdesabou commented Mar 23, 2017

  1. yes it is expected
  2. I can't reproduce this, but as I understand it, it is out of scope of my workflow

Thanks

@vdesabou vdesabou closed this Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment