New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with search on russian language #210

Closed
Nikscorp opened this Issue Oct 27, 2017 · 7 comments

Comments

2 participants
@Nikscorp

Nikscorp commented Oct 27, 2017

screen shot 2017-10-28 at 00 45 08

screen shot 2017-10-28 at 00 45 18

screen shot 2017-10-28 at 00 45 39

So, local search fails with 3+ letters, and works fine with 2 letters in word.
Online search fails always

@vdesabou vdesabou added the bug label Oct 29, 2017

@vdesabou vdesabou self-assigned this Oct 29, 2017

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Oct 31, 2017

Owner

Can you provide the link of the playlist and copy/paste here the name you're looking for ?

I'm trying with random Russian songs and Russian characters but cannot reproduce the issue so far, I only reproduce with Search Online.

Owner

vdesabou commented Oct 31, 2017

Can you provide the link of the playlist and copy/paste here the name you're looking for ?

I'm trying with random Russian songs and Russian characters but cannot reproduce the issue so far, I only reproduce with Search Online.

vdesabou added a commit that referenced this issue Oct 31, 2017

Problems with search on russian language #210
Do not use strtolower when doing api search (causing issues with non
English characters)
@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Oct 31, 2017

Owner

So I've fixed the issue with Search Online, please try this BETA https://transfer.sh/ZqNlN/spotifyminiplayer-beta.alfredworkflow

Please provide the Spotify link for the track you're looking for, I can't find it

Owner

vdesabou commented Oct 31, 2017

So I've fixed the issue with Search Online, please try this BETA https://transfer.sh/ZqNlN/spotifyminiplayer-beta.alfredworkflow

Please provide the Spotify link for the track you're looking for, I can't find it

@Nikscorp

This comment has been minimized.

Show comment
Hide comment
@Nikscorp

Nikscorp Oct 31, 2017

Nikscorp commented Oct 31, 2017

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Oct 31, 2017

Owner

@Nikscorp What I see is that when I type 'Пош', it works:

screenshot 2017-10-31 at 11 15 13

But not when I type 'пош'.

This is actually exactly the same problem as here

Adding ICU support is not something trivial apparently and I'm not sure if that's even possible, so I'm afraid it will remain like this. Unless someone can help with this..

Owner

vdesabou commented Oct 31, 2017

@Nikscorp What I see is that when I type 'Пош', it works:

screenshot 2017-10-31 at 11 15 13

But not when I type 'пош'.

This is actually exactly the same problem as here

Adding ICU support is not something trivial apparently and I'm not sure if that's even possible, so I'm afraid it will remain like this. Unless someone can help with this..

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Oct 31, 2017

Owner

Actually, I found a solution here

Can you please try this beta

Owner

vdesabou commented Oct 31, 2017

Actually, I found a solution here

Can you please try this beta

@Nikscorp

This comment has been minimized.

Show comment
Hide comment
@Nikscorp

Nikscorp Oct 31, 2017

Works fine, thank you!

Nikscorp commented Oct 31, 2017

Works fine, thank you!

@Nikscorp Nikscorp closed this Oct 31, 2017

@vdesabou vdesabou added this to the 7.5 milestone Nov 1, 2017

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Nov 1, 2017

Owner

Leaving opened until 7.5 is released

Owner

vdesabou commented Nov 1, 2017

Leaving opened until 7.5 is released

@vdesabou vdesabou reopened this Nov 1, 2017

@vdesabou vdesabou closed this Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment