New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song notification artwork #224

Closed
Noskcaj19 opened this Issue Jan 12, 2018 · 3 comments

Comments

2 participants
@Noskcaj19

Noskcaj19 commented Jan 12, 2018

Would it be possible to support artwork in the "App Icon" of the song notification like iTunes does? terminal-notifier seems to support this through the -appIcon flag

@vdesabou

This comment has been minimized.

Owner

vdesabou commented Jan 13, 2018

@Noskcaj19

This comment has been minimized.

Noskcaj19 commented Jan 13, 2018

Yes, currently the artwork is displayed in the right side of the notification, along with an icon of the Terminal, which is a bit distracting.

iTunes seems to use a private api to set the left side icon, like this:
itunes

@vdesabou

This comment has been minimized.

Owner

vdesabou commented Jan 16, 2018

So I've updated terminal-notifier and now using appIcon, so instead of:

screenshot 2018-01-16 at 12 01 38

I get:

screenshot 2018-01-16 at 12 01 16

Even though the artwork is smaller, it looks better, so I'll go ahead with modification.

However, you should not see terminal icon in your notifications. You should see Spotify Mini Player icon like I do, see screenshot above.

Can you do this:

screenshot 2018-01-16 at 12 11 11

Then choose Browse to Alfred Workflow folder.

And then double click on Spotify Mini Player.app:

screenshot 2018-01-16 at 12 12 15

If you use another theme (not the green one), I think there is a bug where apps are not present, I've fixed it in next release

@vdesabou vdesabou self-assigned this Jan 16, 2018

@vdesabou vdesabou added this to the 7.7 milestone Jan 16, 2018

vdesabou added a commit that referenced this issue Jan 16, 2018

Song notification artwork #224
Use appIcon instead of contentImage

@vdesabou vdesabou closed this Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment