New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for X in Spotify doesn't work when X is a non-latin #245

Closed
vinceau opened this Issue May 5, 2018 · 6 comments

Comments

2 participants
@vinceau

vinceau commented May 5, 2018

When a search fails to return any results 3 options are presented:

  1. No results found (non-actionable)
  2. Search for X in Spotify
  3. Search for X online

When option 2 is selected and X is non-latin (I've tested Korean, Japanese, and Chinese but I imagine this list is non-exhaustive), no results are found instead "Recent Searches" is shown.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou May 11, 2018

Owner

Hi,

Can you try to install and test with this beta

Owner

vdesabou commented May 11, 2018

Hi,

Can you try to install and test with this beta

@vinceau

This comment has been minimized.

Show comment
Hide comment
@vinceau

vinceau May 11, 2018

Japanese (Hiragana, Katakana, Kanji) and Chinese both seem to be working now in the beta. However, Korean is still broken but instead of showing "Recent Searches" it says "No results found for X" even though when you manually search for X in the search bar, you get results.

vinceau commented May 11, 2018

Japanese (Hiragana, Katakana, Kanji) and Chinese both seem to be working now in the beta. However, Korean is still broken but instead of showing "Recent Searches" it says "No results found for X" even though when you manually search for X in the search bar, you get results.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou May 11, 2018

Owner

Can you copy/paste a Korean artist/song here so that I can reproduce ?

Owner

vdesabou commented May 11, 2018

Can you copy/paste a Korean artist/song here so that I can reproduce ?

@vinceau

This comment has been minimized.

Show comment
Hide comment
@vinceau

vinceau May 11, 2018

You can try with: "아이유" a Korean artist, and "사랑해요" a common song name.

vinceau commented May 11, 2018

You can try with: "아이유" a Korean artist, and "사랑해요" a common song name.

vdesabou added a commit that referenced this issue May 22, 2018

#245
Encode/decode as base64 to avoid issue with Korean search

@vdesabou vdesabou added this to the 7.14 milestone May 22, 2018

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou May 22, 2018

Owner

Sorry for late reply. I think it should be fixed with this beta now : https://transfer.sh/Uzbcu/spotifyminiplayer-beta.alfredworkflow

Let me know

Owner

vdesabou commented May 22, 2018

Sorry for late reply. I think it should be fixed with this beta now : https://transfer.sh/Uzbcu/spotifyminiplayer-beta.alfredworkflow

Let me know

@vinceau

This comment has been minimized.

Show comment
Hide comment
@vinceau

vinceau May 23, 2018

Yup, that fixes it! Thanks a lot!

vinceau commented May 23, 2018

Yup, that fixes it! Thanks a lot!

@vdesabou vdesabou closed this Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment