New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume controls not working (does not decrease) #92

Closed
bjensen opened this Issue Sep 5, 2015 · 8 comments

Comments

2 participants
@bjensen

bjensen commented Sep 5, 2015

Hi guys,

First off, hands down to you for making such a cool tool

When I select the "Volume down" then I get the notification "spotify volume has been decreased by 20%", however the slider in spotify has moved up! Thus increasing the volume and when I use the Volume up option the volume is set to 100%!

What have I done wrong?

The version of the spotify client is 1.0.13.108.gcd94e7db

I am controlling a speaker through spotify connect, I dont know if that has anything to do with it..

I just installed the app and made a spotify app etc, so everything is the latest version.

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Sep 6, 2015

Owner

Hi,

That's strange, even when I control a speaker using spotify connect, I do not see this behavior.
What I notice is that the volume slider does not move at all when I use Spotify Connect on my side, but the sound itself is decreased or increased..

Is it reproducible every time on your side ?
What happens if you do not use a spotify connect speaker? Is volume decrease working in that case?

Thanks

Owner

vdesabou commented Sep 6, 2015

Hi,

That's strange, even when I control a speaker using spotify connect, I do not see this behavior.
What I notice is that the volume slider does not move at all when I use Spotify Connect on my side, but the sound itself is decreased or increased..

Is it reproducible every time on your side ?
What happens if you do not use a spotify connect speaker? Is volume decrease working in that case?

Thanks

@vdesabou vdesabou self-assigned this Sep 6, 2015

@vdesabou vdesabou added the question label Sep 6, 2015

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Sep 6, 2015

Owner

Oh..I upgraded to 1.0.13.108.gcd94e7db and now it looks like everything related to volume is messed up..
Looks like another new AppleScript bug :(

Owner

vdesabou commented Sep 6, 2015

Oh..I upgraded to 1.0.13.108.gcd94e7db and now it looks like everything related to volume is messed up..
Looks like another new AppleScript bug :(

@bjensen

This comment has been minimized.

Show comment
Hide comment
@bjensen

bjensen Sep 6, 2015

Hi vdesabou,

Thanks for the response.

Yes, its very weird...I just did some more testing without spotify connect

When I first first started out using volume up then it worked just fine..

However afterwards it seams like volume up sets the sound to about 20%
and volume down sets it to 90%

bjensen commented Sep 6, 2015

Hi vdesabou,

Thanks for the response.

Yes, its very weird...I just did some more testing without spotify connect

When I first first started out using volume up then it worked just fine..

However afterwards it seams like volume up sets the sound to about 20%
and volume down sets it to 90%

@vdesabou vdesabou added bug known issue and removed question labels Sep 7, 2015

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Sep 7, 2015

Owner

This issue has been reported here, you can Kudo it to have this fixed.

This is a regression, I'm not sure I can do much on my side to work around this..

Owner

vdesabou commented Sep 7, 2015

This issue has been reported here, you can Kudo it to have this fixed.

This is a regression, I'm not sure I can do much on my side to work around this..

@bjensen

This comment has been minimized.

Show comment
Hide comment
@bjensen

bjensen Sep 7, 2015

Well according to the poster of the link a fix would be to set the volume and pause and start the music again? Perhaps it could be so hard one wouldn't notice... Well we could do this till the script is fixed?

On Mon, Sep 7, 2015 at 2:06 PM, Vincent notifications@github.com wrote:

This issue has been reported here, you can Kudo it to have this fixed.

This is a regression, I'm not sure I can do much on my side to work around this..

Reply to this email directly or view it on GitHub:
#92 (comment)

bjensen commented Sep 7, 2015

Well according to the poster of the link a fix would be to set the volume and pause and start the music again? Perhaps it could be so hard one wouldn't notice... Well we could do this till the script is fixed?

On Mon, Sep 7, 2015 at 2:06 PM, Vincent notifications@github.com wrote:

This issue has been reported here, you can Kudo it to have this fixed.

This is a regression, I'm not sure I can do much on my side to work around this..

Reply to this email directly or view it on GitHub:
#92 (comment)

vdesabou added a commit that referenced this issue Sep 8, 2015

Workaround for #92
FIX THIS: Workaround for #92
#92
To remove once Spotify fixes the issue.
@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Sep 8, 2015

Owner

I've implemented the workaround, but I don't like it as there is a small interruption of the track when we increase/decrease/mute/unmute volume...

Owner

vdesabou commented Sep 8, 2015

I've implemented the workaround, but I don't like it as there is a small interruption of the track when we increase/decrease/mute/unmute volume...

@bjensen

This comment has been minimized.

Show comment
Hide comment
@bjensen

bjensen Sep 8, 2015

Im currently using your beta and I hardly notice the interruption and considering the alternative would be to deactivate the volume control since it is broken then I think its a great workaround :-) (y)

bjensen commented Sep 8, 2015

Im currently using your beta and I hardly notice the interruption and considering the alternative would be to deactivate the volume control since it is broken then I think its a great workaround :-) (y)

@vdesabou vdesabou changed the title from Volume controls not working (does not decrease) on spotify connect to Volume controls not working (does not decrease) Sep 11, 2015

@vdesabou

This comment has been minimized.

Show comment
Hide comment
@vdesabou

vdesabou Sep 11, 2015

Owner

Version 6.2.3 is live

Owner

vdesabou commented Sep 11, 2015

Version 6.2.3 is live

@vdesabou vdesabou closed this Sep 11, 2015

vdesabou added a commit that referenced this issue Sep 22, 2015

Revert "Workaround for #92"
This reverts commit e71fde4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment