Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross-signing on /develop #12126

Merged
merged 1 commit into from Jan 29, 2020
Merged

Enable cross-signing on /develop #12126

merged 1 commit into from Jan 29, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 29, 2020

No description provided.

@t3chguy t3chguy requested a review from Jan 29, 2020
Copy link
Member

@turt2live turt2live left a comment

lgtm as a change, barring discussions regarding whether this is a good idea

I can't deploy this one

@jryans jryans added this to In Review in Web App Team Jan 29, 2020
@jryans
Copy link
Contributor

@jryans jryans commented Jan 29, 2020

Waiting for internal alignment that we've polished things enough for exposure to develop.

@jryans
Copy link
Contributor

@jryans jryans commented Jan 29, 2020

This is blocked on clarifying device name, ID in toasts, as well as changing to devices -> sessions in Settings copy (will PR now).

@t3chguy
Copy link
Member Author

@t3chguy t3chguy commented Jan 29, 2020

1 part done: matrix-org/matrix-react-sdk#3978

@jryans
Copy link
Contributor

@jryans jryans commented Jan 29, 2020

Last blocking PR: matrix-org/matrix-react-sdk#3980

@jryans
Copy link
Contributor

@jryans jryans commented Jan 29, 2020

Blocked PRs completed, waiting for CI to push them live on develop.

@jryans
Copy link
Contributor

@jryans jryans commented Jan 29, 2020

I'll merge this now, and wait to deploy once develop is confirmed ready.

@jryans jryans merged commit 98b8ba2 into develop Jan 29, 2020
7 checks passed
Web App Team automation moved this from In Review to In Test Jan 29, 2020
@jryans
Copy link
Contributor

@jryans jryans commented Jan 30, 2020

This is now live on develop! 🎉

@jryans jryans added the phase:1 label Feb 10, 2020
@t3chguy t3chguy deleted the t3chguy/develop_cs branch May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants