Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flescio/create room action #925

Merged
merged 9 commits into from May 22, 2023
Merged

Flescio/create room action #925

merged 9 commits into from May 22, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented May 19, 2023

Fix a UI bug in the invites screen
Resolve #630
Add the creation action of a room.
Add the task runner with timeout.
After a room is created it's not available right away, so it waits for the room id and room name to be present in the room summary list.

room-creation

@github-actions
Copy link

github-actions bot commented May 19, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f662e21

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 16.12% and project coverage change: -0.17 ⚠️

Comparison is base (9afc0c0) 49.14% compared to head (9a403c4) 48.98%.

❗ Current head 9a403c4 differs from pull request most recent head f662e21. Consider uploading reports for the commit f662e21 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #925      +/-   ##
===========================================
- Coverage    49.14%   48.98%   -0.17%     
===========================================
  Files          330      330              
  Lines        20025    20120      +95     
  Branches     11054    11100      +46     
===========================================
+ Hits          9842     9856      +14     
- Misses        9906     9985      +79     
- Partials       277      279       +2     
Flag Coverage Δ
unittests 22.78% <16.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/Screens/CreateRoom/CreateRoomCoordinator.swift 0.00% <0.00%> (ø)
.../Sources/Screens/CreateRoom/CreateRoomModels.swift 100.00% <ø> (ø)
...ces/Screens/CreateRoom/View/CreateRoomScreen.swift 0.00% <0.00%> (ø)
...ens/InviteUsersScreen/View/InviteUsersScreen.swift 40.00% <0.00%> (-20.21%) ⬇️
...s/StartChatScreen/StartChatScreenCoordinator.swift 15.73% <0.00%> (-0.18%) ⬇️
...ens/StartChatScreen/StartChatScreenViewModel.swift 44.82% <0.00%> (-1.20%) ⬇️
ElementX/Sources/Services/Client/ClientProxy.swift 38.56% <0.00%> (-3.24%) ⬇️
.../Sources/Services/Client/ClientProxyProtocol.swift 0.00% <ø> (ø)
...Room/RoomSummary/RoomSummaryProviderProtocol.swift 26.92% <0.00%> (-11.97%) ⬇️
...urces/Screens/CreateRoom/CreateRoomViewModel.swift 50.00% <7.31%> (-45.00%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flescio flescio marked this pull request as ready for review May 19, 2023 12:12
@flescio flescio requested a review from a team as a code owner May 19, 2023 12:12
@flescio flescio requested review from stefanceriu and removed request for a team May 19, 2023 12:12
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I left some comments inline 👍

ElementX/Sources/Services/Client/ClientProxy.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Client/ClientProxy.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/Runner.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/Runner.swift Outdated Show resolved Hide resolved
@flescio flescio requested a review from stefanceriu May 22, 2023 14:01
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀it!

@flescio flescio force-pushed the flescio/create_room_action branch from 9a403c4 to f662e21 Compare May 22, 2023 15:17
@flescio flescio enabled auto-merge (squash) May 22, 2023 15:17
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flescio flescio merged commit beb61d1 into develop May 22, 2023
6 checks passed
@flescio flescio deleted the flescio/create_room_action branch May 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a room and show it
2 participants