Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case of no IS in features that require IS to lookup #3277

Closed
jryans opened this issue Aug 28, 2019 · 1 comment

Comments

@jryans
Copy link
Member

commented Aug 28, 2019

Cloned from vector-im/riot-web#10619.

Since it's now possible to be disconnected from an identity server entirely (your session has no active identity server), it's unclear how features that require an IS to function should behave.

For the case of the Discovery section in Settings, it's easy enough: you have no IS, so we don't show any 3PIDs to control.

However, there are other IS-using features in Riot, like:

  1. Inviting by 3PID
  2. (There might be more such features in mobile, so please add if so.)
BillCarsonFr pushed a commit that referenced this issue Sep 16, 2019
Valere
Fixes #3277
Ensure contact manager handle the case when no IS is defined
@BillCarsonFr

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Here c6e1b18
image

@BillCarsonFr BillCarsonFr self-assigned this Sep 16, 2019
BillCarsonFr pushed a commit that referenced this issue Sep 17, 2019
Ensure contact manager handle the case when no IS is defined
BillCarsonFr pushed a commit that referenced this issue Sep 25, 2019
Ensure contact manager handle the case when no IS is defined
BillCarsonFr pushed a commit that referenced this issue Oct 1, 2019
Ensure contact manager handle the case when no IS is defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.