Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `id_access_token` in CS API when required #3295

Closed
manuroe opened this issue Sep 9, 2019 · 3 comments

Comments

@manuroe
Copy link
Member

commented Sep 9, 2019

Make sure we pass the token on CS APIs that need it, ie:

  • inviteByThreePid: POST /rooms/$roomId/invite
  • all /requestToken APIs:
    • /register/email/requestToken
    • /register/msisdn/requestToken
    • /account/3pid/email/requestToken
    • /account/3pid/msisdn/requestToken
    • /account/password/email/requestToken
    • /account/password/msisdn/requestToken
@manuroe

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

With https://github.com/matrix-org/matrix-doc/blob/anoa/msc_separate_hs_api/proposals/2290-separate-threepid-bind-hs.md, it seems we will not need this token for:
- /account/3pid/email/requestToken
- /account/3pid/msisdn/requestToken
- /account/password/email/requestToken
- /account/password/msisdn/requestToken

TODO: douche check this and check requirements for others. Then, update the issue.

@BillCarsonFr BillCarsonFr self-assigned this Sep 16, 2019
@anoadragon453

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

The required endpoints should just be:

  • POST /rooms/$roomId/invite
  • POST /createRoom

The /requestToken endpoints (at least password and registration) shouldn't need it. I'll try to figure out what's up.

@BillCarsonFr

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

See #3322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.