Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include ID server or access token when HS supports MSC2290 #3322

Open
jryans opened this issue Sep 23, 2019 · 1 comment

Comments

@jryans
Copy link
Member

commented Sep 23, 2019

Cloned from vector-im/riot-web#10933

For HSes that support MSC2290 (as indicated by m.separate_add_and_bind: true), we need to remove id_server and id_access_token from all requestToken calls to the homeserver.

This is an important UX step, as otherwise we would try to create a token with the IS, which additionally means present terms to the user for a service we're not actually meant to be using.

@BillCarsonFr

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@jryans Currently riot android does not send these if doesRequiresIdentityServer is false. Do we need to change and check against separate_add_and_bind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.