Upgrade to electron 8.0.1 and implement spellchecking #30
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
There was a problem hiding this comment.
🎉 thanks! Looking forward to finally having spell checking!
Does electron support viewing the list of words you've added to the custom dictionary? Either way we should probably file a bug to add support for this as it's a little cruel to not be able to remove a mis-spelling if you accidentally add it to the dictionary.
Did you find why Riot crashed when Ryan tried to upgrade to Electron 8 a couple of releases back?
| options.push({ | ||
| label: word, | ||
| click: (menuItem, browserWindow) => { | ||
| browserWindow.webContents.replaceMisspelling(word); |
There was a problem hiding this comment.
I guess this knows what to replace by what the user has highlighted since it's an editing command? The docs seem pretty scarce - either way it look like you're doing the correct thing.
There was a problem hiding this comment.
indeed, and empirically it does work. When you right click a misspelt word it highlights the entire word before showing the context menu
Nope I don't see an API to even remove words from the custom dict at this time.
is there any log of this? @jryans |
OK - we should probably file a collection of bugs around this (dictionary words should probably be stored on your account data, they won't be removed when you log out). Do you want to or shall I? Related: electron/electron#22161 |
|
Related electron/electron#22368 |
Are you suggesting we store custom words in Matrix and re-hydrate client spellcheckers when the user logs in and sync them between clients (not sure how possible this will be on the mobile apps) or that we simply wipe custom dictionary when the user logs out? |
Unfortunately no log... 😭 Electron 8.0.0 crashed on startup for macOS at least, so I abandoned it at the time. |
Probably at least that we wipe the custom dictionary when you log out, although ideally it should probably somehow be stored on your account so you don't have to add all the words again if you log out & log in again. That does imply some level of syncing, yeah, but I don't think we need to worry about mobile apps, at least not for now. |
Electron 8.0.1 appears to work here, so maybe we're safe now! |
|
Woot! \o/ |
|
@geckolinux this only applies to the Nightly package at the moment. 1.16 (not to be confused with 1.15.16) will have this, but not earlier. |
|
1.6* |
|
Is there a way to disable spell checking? |
|
This is not a support channel. |
Fixes element-hq/element-web#2661
Requires matrix-org/matrix-react-sdk#4121 and element-hq/element-web#12487