Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spontaneous logouts #1643

Open
ara4n opened this issue Nov 7, 2017 · 13 comments
Open

Spontaneous logouts #1643

ara4n opened this issue Nov 7, 2017 · 13 comments
Labels
P1

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Nov 7, 2017

Since 0.5.6 i (and Amandine) have had intermittent spontaneous logouts - typically once every few weeks; sometimes more often. The pattern is hard to spot.

matrix-org/riot-ios-rageshakes#417 is the rageshake; cross-posting here for a public tracker for it & to prioritise it.

Given 0.5.6 is an appstore release this isn't necessarily a regression, but it's very very annoying when it happens (especially wrt E2E keys). I don't think this should block the upcoming build in the end.

@ara4n ara4n added the P1 label Nov 7, 2017
@giomfo

This comment has been minimized.

Copy link
Contributor

@giomfo giomfo commented Nov 24, 2017

first related commit: dd4d1a4

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Feb 6, 2018

The issue is still here in 0.6.8.
The bug seems to happen after the device died because of low battery like at matrix-org/riot-ios-rageshakes#835.

@manuroe manuroe reopened this Feb 6, 2018
@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Feb 6, 2018

Note that the test [UIApplication isProtectedDataAvailable] we used to do is not the single condition to make the false logout issue appear.
The result can be NO and the app opens normally like in the log at https://riot.im/bugreports/listing/2018-02-03/190103/console.log.gz.

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Feb 6, 2018

Note for end users: if it happens, do not log in, you will lose your e2e messages.
But kill the app and relaunch it. It should start normally.

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Feb 8, 2018

Another report on 0.6.8: matrix-org/riot-ios-rageshakes#924

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Feb 21, 2018

Issue is still in 0.6.10: matrix-org/riot-ios-rageshakes#967

@manuroe

This comment has been minimized.

@aaronraimist

This comment has been minimized.

Copy link

@aaronraimist aaronraimist commented Oct 31, 2018

Still in 0.7.6, just submitted a rageshake

@ara4n

This comment has been minimized.

Copy link
Member Author

@ara4n ara4n commented Oct 31, 2018

these drive me mad. @manuroe can we not just crash the app rather than display the spurious login screen?

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Nov 5, 2018

these drive me mad. @manuroe can we not just crash the app rather than display the spurious login screen?

When we detect the system is not ready to provide us with user credentials, we make the app crashes. But that detection does not work every time.

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Jul 26, 2019

Another instance of this bug from A: matrix-org/riot-ios-rageshakes#2677

In this case, the first log is:

2019-07-25 23:23:41.399 Riot[189:2845] [AppDelegate] applicationWillEnterForeground

There is no trace of logs from [AppDelegate initialize] and [AppDelegate willFinishLaunchingWithOptions] that should happen before.

@manuroe

This comment has been minimized.

Copy link
Member

@manuroe manuroe commented Jul 26, 2019

There is no trace of logs from [AppDelegate initialize]

This method should have been called. This is it that sets up logs to be stored in files :|

@Shirk

This comment has been minimized.

Copy link

@Shirk Shirk commented Dec 2, 2019

So 2 years later, with the issue being P1 Riot on iOS still regularly randomly kicks me out and urges me as well as all my contacts to re-verify each other once again.

Is this really seriously being looked into?

Why does a logout and re-login on the same device with existing device keys cause new keys to be generated in the first place?

[EDIT] Maybe this:

Note for end users: if it happens, do not log in, you will lose your e2e messages.
But kill the app and relaunch it. It should start normally.

Would be something to feature prominently on the login screen for everyone who encounters this issue instead of having it in a bug tracker that the normal user would probably not even know how to find.

[EDIT2] looking at the code, try to overload +load or -init both of them are granted to be called always +initialize isn't necessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.