New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiceover support for accessibility #1842

Open
ara4n opened this Issue Apr 15, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@MarcoZehe

This comment has been minimized.

MarcoZehe commented Apr 29, 2018

I am also a VoiceOver user affected by the lack of support, and am experienced in providing advice for implementation if you get stuck. Ping me if you need anything! :)

@ara4n

This comment has been minimized.

Member

ara4n commented Apr 29, 2018

we don’t have bandwidth in the core team to add voiceover support atm, sadly - it will likely have to come from the community as a contribution.

@manuroe

This comment has been minimized.

Member

manuroe commented Apr 30, 2018

We have a PR for this on Android at vector-im/riot-android#1762.

@MarcoZehe

This comment has been minimized.

MarcoZehe commented Apr 30, 2018

einMarco added a commit to einMarco/riot-ios that referenced this issue Jun 20, 2018

einMarco added a commit to einMarco/riot-ios that referenced this issue Jun 20, 2018

Added accessibility labels for issue: "Voiceover support for accessib…
…ility vector-im#1842"

Signed-off-by: Marco Seizew <ein_marco@rausrufezeichen.de>

manuroe added a commit that referenced this issue Jun 25, 2018

Merge pull request #1906 from einMarco/master
Added accessibility labels for issue: "Voiceover support for accessibility #1842"
@ara4n

This comment has been minimized.

Member

ara4n commented Oct 5, 2018

@manuroe is this closed by #1906?

@aaronraimist

This comment has been minimized.

aaronraimist commented Oct 14, 2018

@ara4n no.

@mrkiko:matrix.org on things that can be improved:

As an example, it seems VoiceOver is not able to “detect” screen updates correctly on rooms windows like this one, I am not able thus, to read all the messages in there. Double tapping on people or room names in the home screen does not work (nothing happens), it is difficult and something not possible to dismiss the keyboard (so submitting a bug report is not easy when VoiceOver is active), read receipts infos not accessible. And some buttons in private chat windows are not labeled. This is meant only to be a technical answer

Pulled out into individual changes:

  • VoiceOver is not able to “detect” screen updates correctly on rooms windows, I am not able to read all the messages in Riot iOS room (and others presumably)
  • Double tapping on people or room names in the home screen does not work (nothing happens) #1433
  • it is difficult and sometimes not possible to dismiss the keyboard (so submitting a bug report is not easy when VoiceOver is active)
  • read receipts not accessible
  • some buttons in private chat windows are not labeled

Things I found:
Home screen:

  • Search doesn't seem to work on home screen (I found this but maybe I am using VoiceOver incorrectly)
  • Not possible to create or join a new room using the big + button

Room view:

  • Message detail buttons are not well labeled, ex share button is called "Room VC event menu alert action share button"
  • Text field to send a message is totally unlabeled, no way to tell if the message you are sending is encrypted or not
  • Photo uploading doesn't work at all, the native picker in iMessage is great
  • WOW "viewing" photos in iMessage is great, can we tap in to the native support for detecting what is in a photo
  • Easy to get stuck in the photo gallery viewer, I couldn't find a way to get out

List of rooms view:

  • Room divider should probably say the number of rooms first, example: "75 rooms" not "rooms 75"

E2E:

  • not possible to re-request encryption keys
  • E2E device verification SUCKS for blind users. I'm hoping something with the QR codes will be an improvement but right now it tries to pronounce the device ID and then reads the device key super quickly so there is no way a blind user could verify devices.
  • E2E can't type in the "confirm passphrase" field without specifically tapping on it
@mrkiko

This comment has been minimized.

mrkiko commented Oct 14, 2018

@aaronraimist I can confirm searching doesn't work as, at least I, expect when in Home.
I am here, and I am also at full disposal.
BTW - if needed I can apply to TestFlighty if I amasked to.

@aaronraimist

This comment has been minimized.

aaronraimist commented Oct 14, 2018

@mrkiko Yeah it would probably be good if you did so you could test the changes as they are made. You can join the beta at this link: https://testflight.apple.com/join/lCeTuDKM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment