Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to accept integration manager polices on use #10088

Closed
lampholder opened this issue Jun 18, 2019 · 10 comments · Fixed by matrix-org/matrix-react-sdk#3199

Comments

@lampholder
Copy link
Member

commented Jun 18, 2019

Before you:

  • add a widget to a room
  • allow a widget to load for you in a room
  • use the sticker picker

You must read and agree to the policy documents provided by the integration manager

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

This will require a change to scalar (to expose a policy document) - will this also require a spec change?

@turt2live

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

will this also require a spec change?

see #10087 (comment)

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

We considered whether it would be possible for Scalar to handle this "internally" (i.e. scalar presents HTML that gets rendered in iframes in Riot, so why not just let it do this same trick to handle t's and c's acceptance) - however, by the time it rendered such an acceptance UX you would already have shared the mxid with the integration manager via OpenID, so this is not feasible.

@nadonomy

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

After validating today, latest comps are in Zeplin: https://zpl.io/brMdWo3

@nadonomy nadonomy removed the needs-design label Jul 5, 2019
@jryans jryans self-assigned this Jul 10, 2019
@jryans jryans added this to In Progress in Workflow via automation Jul 10, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 22, 2019
This defers the work to request the IM token when displaying a widget until
after we know that widget will actually be shown and the user has granted
permission for this widget to be displayed.

This is useful in general to avoid making unnecessary token checks, but it's
particularly helpful with the new Terms API, so that we only show the Terms flow
when widget are actually being used (as opposed to entering the room where
widgets exist, but haven't been shown / permitted).

Part of vector-im/riot-web#10088
@jryans jryans added the type:widgets label Jul 22, 2019
@jryans

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

One portion fixed by matrix-org/matrix-react-sdk#3240

@jryans

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

The rest of this issue will be fixed by matrix-org/matrix-react-sdk#3199

@jryans jryans moved this from In Progress to In Review in Workflow Jul 22, 2019
Workflow automation moved this from In Review to In Test Jul 23, 2019
@jryans

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

For historical tracking, I did not notice the in-context agreement tooltips from the Zeplin designs while working on this, so this only makes the general terms modal appear at the right moments.

@jryans

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

(If we still want the in-context agreement tooltips from the design, we should file a new issue to track that.)

@manuroe

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Kamino cloned this issue to vector-im/riot-ios

@jryans

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Filed #10422 for the more contextual version intended by the designs.

@jryans jryans moved this from In Test to In RC in Workflow Aug 1, 2019
@jryans jryans moved this from In RC to Done in Workflow Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.