Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple setting an email for password reset from publishing your threepid to the identity server and support choice of identity server (on registration) #10091

Open
lampholder opened this issue Jun 18, 2019 · 6 comments

Comments

@lampholder
Copy link
Member

commented Jun 18, 2019

image

@t3chguy

This comment has been minimized.

Copy link
Collaborator

commented Jun 23, 2019

Setting an e-mail for password reset also allows the enablement of e-mail notifications being sent to it

@dbkr dbkr moved this from In Progress to In Review in Workflow Jun 24, 2019

@lampholder lampholder changed the title Decouple setting an email for password reset from publishing your threepid to the identity server Decouple setting an email for password reset from publishing your threepid to the identity server (on registration) Jun 25, 2019

@lampholder lampholder changed the title Decouple setting an email for password reset from publishing your threepid to the identity server (on registration) Decouple setting an email for password reset from publishing your threepid to the identity server and support choice of identity server (on registration) Jun 25, 2019

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

Setting an e-mail for password reset also allows the enablement of e-mail notifications being sent to it

I don't think this needs calling out in the UX specifically, since you're not opted into email notifications by default (I just verified this).

@aaronraimist

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

Did you test with a new account or adding an email to your existing account? I’m pretty sure new accounts do have email notifications enabled by default.

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

I did test with a new account - I just tested adding an email addres sto an old account and email notifs weren't enabled by default (in this instance at least).

Do you have a counter example?

@aaronraimist

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

I guess not. I just tried it with a new account and it worked as you said. Maybe that behavior changed since I created my account because I'm pretty sure it was enabled by default in the past.

@nadonomy

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

After validating today, latest comps are in Zeplin: https://zpl.io/brMdWo3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.