Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store identity server in Account Data and support choosing identity server integration in User Settings #10094

Closed
lampholder opened this issue Jun 18, 2019 · 10 comments · Fixed by matrix-org/matrix-react-sdk#3320

Comments

@lampholder
Copy link
Member

commented Jun 18, 2019

2019-08-02 at 15 28

2019-08-02 at 15 29

Additional requirements:

  • when we change IS, we'll need to fetch its policy docs and capture that the user has agreed to them
  • we should probably also validate that it's really an IS
  • we should also somehow validate that the HS permits access to this IS if it maintains a whitelist...
@turt2live

This comment was marked as outdated.

Copy link
Member

commented Jun 18, 2019

Closing in favour of #5921

@lampholder

This comment was marked as outdated.

Copy link
Member Author

commented Jun 19, 2019

Hey @turt2live - I think #5921 is not a dup of this, since the intention of this is to expose this as an option within UserSettings so that a user can change their IS mid flight.

It could be that that's an assumption baked into #5921, but it wasn't obvious to me.

@lampholder lampholder changed the title Support changing (or disabling) identity server integration in User Settings Store identity server in Account Data and support choosing identity server integration in User Settings Jun 25, 2019
@nadonomy nadonomy removed the needs-design label Jul 5, 2019
@nadonomy

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

After validating today, latest comps are in Zeplin: https://zpl.io/brMdWo3

@dbkr

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

One thing that's not clear on this is how this should work with all the other places that specify ISes, ie. if the one you had at login time (be that from your client's default, .well-known or entered), is that then discarded in favour of using the one in your account settings? I'm going to assume so for now.

@jryans

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Another complexity is that (similar to the Disconnect button in #10425), we need to ensure all your 3PIDs are unbound (both on the IS itself and also the HS record of where your 3PIDs are bound) before actually changing the IS.

@dbkr dbkr added this to In Progress in Workflow Aug 7, 2019
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
Just changes the current ID server being used

To come in subsequent PRs:
 * Store this in account data
 * Check for terms or support the proper UI for accepting terms when setting
 * Support disconnecting

Part 1 of vector-im/riot-web#10094
Requires matrix-org/matrix-js-sdk#1013
@lampholder

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

One thing that's not clear on this is how this should work with all the other places that specify ISes, ie. if the one you had at login time (be that from your client's default, .well-known or entered), is that then discarded in favour of using the one in your account settings? I'm going to assume so for now.

We should no longer have an IS 'supplied at login time' - rather there is a 'default' that is 'the Identity Server the client would prompt to use if asked to do something identity servery and the user has not made an active choice to use either a different identity server or no identity servrer at all'.

This 'default' could be specified in the config.json or in .well-known (I can't think of anywhere else sensible to provide this at the moment), or it could not be specified at all.

There is an unanswered question about what we do if an admin wants to provide a matrix stack with a locked-down IS choice. I think answering this question is hard, so despite the risk of our painting ourselves into a corner with the proposed, I'd like to keep a lid on this for now and tackle it if/when we have a concrete usecase to consider.

@dbkr

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

The nice inline terms dialog has been spun out to #10539 as it's not as critial-path as the rest of this.

@dbkr

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Second part of this is done. I think @turt2live is working on the first part.

@manuroe

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Kamino cloned this issue to vector-im/riot-ios

@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

I've reclaimed this for the storing in account data part. matrix-org/matrix-react-sdk#3300 has been added to "in test" for Dave's portion of the work.

MSC I need to care about: matrix-org/matrix-doc#2230

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 16, 2019
@turt2live turt2live moved this from In Progress to In Review in Workflow Aug 16, 2019
Workflow automation moved this from In Review to In Test Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
6 participants
You can’t perform that action at this time.