Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Integration Manager preferences in account data and allow user to change them somewhere sensible #10161

Closed
lampholder opened this issue Jun 25, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3308

Comments

@lampholder
Copy link
Member

commented Jun 25, 2019

The User Settings UX for #4913, basically.

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

I don't think there's any benefit to my mocking up a UX for this - there are quite a few places one could put this UX :\

It could be implemented in User Settings (along the lines of #10094) or it could be in the IM UX somewhere).

What we need (as a minimum) is for a user to be able to:

  • choose not to use an IM at all
    • and Riot should handle this gracefully
    • they should be made aware that this isn't going to do anything to existing widgets
  • choose a different IM
    • we should verify that it is an IM
    • we should prompt the user to ready and accept the IM's policy docs
      • (does this need to be done at config change, or at first use?)
    • existing widgets should 'just work'
@lampholder lampholder changed the title User Settings UX to change Integration Manager Store Integration Manager preferences in account data and allow user to change them somewhere sensible Jun 25, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

proposal for this: matrix-org/matrix-doc#1957 (cc from #4913)

@nadonomy

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

After validating today, latest comps are in Zeplin, as a part of registration & settings: https://zpl.io/brMdWo3

@nadonomy nadonomy removed the needs-design label Jul 5, 2019
@jryans jryans added phase:2 and removed phase:1 labels Jul 19, 2019
@Mikaela Mikaela referenced this issue Jul 24, 2019
1 of 4 tasks complete
@turt2live turt2live self-assigned this Aug 7, 2019
@turt2live turt2live added this to In Progress in Workflow via automation Aug 7, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
It was already in a common place, but this is the boilerplate for supporting multiple integration managers, and multiple integration manager sources. 

For vector-im/riot-web#4913 / vector-im/riot-web#10161
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
For vector-im/riot-web#4913 / vector-im/riot-web#10161

Relies on the structure defined by [MSC1957](matrix-org/matrix-doc#1957)

This is just the bit of code to parse the user's widgets (while watching for changes) and allow for it to be the default manager.
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Terms acceptance is #10539

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 12, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 12, 2019
@turt2live turt2live moved this from In Progress to In Review in Workflow Aug 12, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Workflow automation moved this from In Review to In Test Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
4 participants
You can’t perform that action at this time.