Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flags for reactions and edits #10282

Closed
jryans opened this issue Jul 8, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3233
Closed

Remove feature flags for reactions and edits #10282

jryans opened this issue Jul 8, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3233

Comments

@jryans
Copy link
Member

@jryans jryans commented Jul 8, 2019

Once we're confident that reactions and edits are stable, we can remove the feature flags.

@jryans jryans changed the title Remove feature flags for reactions and edits Remove feature flags and unstable URLs for reactions and edits Jul 10, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

@jryans jryans commented Jul 10, 2019

We've decided it's best to handle both feature flags and unstable URLs together: a feature should be allowed to use to unstable APIs while it has a feature flag, but it should change to specced and versioned APIs when the flags are removed.

@bwindels

This comment has been minimized.

Copy link
Contributor

@bwindels bwindels commented Jul 15, 2019

Seems like quite a bit away from being able to do this, with backend and spec work stalled. Removing phase tag for now.

@bwindels bwindels removed the phase:3 label Jul 15, 2019
@jryans jryans changed the title Remove feature flags and unstable URLs for reactions and edits Remove feature flags for reactions and edits Jul 17, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

@jryans jryans commented Jul 17, 2019

Reducing scope back down to just the feature flags. It turns out that we don't have a clear system to keep a feature flag in the code and default it on without config work for deployments, so it's best to remove the flags now to get the features out to everyone.

Filed a new issue #10361 for the future work around unstable URLs.

@jryans jryans added the phase:2 label Jul 17, 2019
@jryans jryans self-assigned this Jul 17, 2019
@jryans jryans added this to In Progress in Workflow via automation Jul 17, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
@jryans jryans moved this from In Progress to In Review in Workflow Jul 17, 2019
Workflow automation moved this from In Review to In Test Jul 18, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

@jryans jryans commented Jul 18, 2019

Merged to React SDK 1.4.0 release branch in matrix-org/matrix-react-sdk#3233

jryans added a commit that referenced this issue Jul 18, 2019
jryans added a commit that referenced this issue Jul 18, 2019
jryans added a commit that referenced this issue Jul 18, 2019
jryans added a commit that referenced this issue Jul 18, 2019
@jryans jryans moved this from In Test to Done in Workflow Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.