Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms modal prompt should appear without a flash of the integration manager portal first #10386

Closed
jryans opened this issue Jul 22, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3242

Comments

@jryans
Copy link
Member

commented Jul 22, 2019

At the moment, when testing the terms support from matrix-org/matrix-react-sdk#3199, whenever we need to display terms for the IM API, the following happens:

  1. IM portal modal briefly appears for ~1 sec
  2. Terms modal replaces it with different content in a differently sized box

It's a bit glitchy feeling UX-wise.

@jryans jryans self-assigned this Jul 22, 2019
@jryans jryans added this to In Progress in Workflow via automation Jul 22, 2019
@jryans jryans moved this from In Progress to In Review in Workflow Jul 22, 2019
@jryans jryans moved this from In Review to In Progress in Workflow Jul 22, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 23, 2019
This avoids a visual glitch where the Integration Manager portal would briefly
appear, but then be replaced by a smaller Terms dialog when there's something to
agree to.

To resolve this minimal code churn, this cheats a bit and customises the size of
the terms dialog to match the IM portal modal when terms are shown for IM
purposes.

Fixes vector-im/riot-web#10386
@jryans jryans moved this from In Progress to In Review in Workflow Jul 23, 2019
Workflow automation moved this from In Review to In Test Jul 24, 2019
@jryans jryans moved this from In Test to In RC in Workflow Aug 1, 2019
@jryans jryans moved this from In RC to Done in Workflow Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.