Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discovery and account 3PID sections when either changes #10519

Closed
jryans opened this issue Aug 7, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3419

Comments

@jryans
Copy link
Member

commented Aug 7, 2019

The first cut of sharing / revoking 3PIDs from #10159 is slightly awkward, as the discovery and account sections each have a list of 3PIDs, but they don't currently update in response to changes from the other section.

This requires reworking some the settings state management.

@jryans jryans added phase:1 and removed phase:2 labels Sep 6, 2019
@jryans jryans self-assigned this Sep 9, 2019
@jryans jryans added this to In Progress in Workflow via automation Sep 9, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 11, 2019
This pulls the 3PID state management in Settings up to a single location so that
the Account and Discovery sections now work from a single list that updates
immediately.

Fixes vector-im/riot-web#10519
@jryans jryans moved this from In Progress to In Review in Workflow Sep 11, 2019
Workflow automation moved this from In Review to In Test Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
1 participant
You can’t perform that action at this time.