Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle terms agreement in the Discovery section of settings #10522

Closed
jryans opened this issue Aug 8, 2019 · 6 comments

Comments

@jryans
Copy link
Member

commented Aug 8, 2019

It's possible that the Discovery section of settings is the first place the user interacts with their identity server, and therefore we need to show some kind of state when terms haven't been agreed yet, allow for agreeing the terms, etc.

Maybe something like "⚠️ You need to agree to Identity Server terms before you can share your email addresses and phone numbers. " inline in the Discovery section?

@nadonomy

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@jryans yep this sounds totally reasonable!

Looking at the design, I think the best thing to do would be to hide all of the Discovery section content and display this warning in place, as I think it'll just provide more noise than value if we expose it in a disabled/low alpha state.

Does that sound good to you? If so let me know and I can update Sketch/Zeplin with the warning.

@jryans jryans added the feature label Aug 8, 2019

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Yes, I think that sounds reasonable for the issue described here. I recently also raised #10525, which makes me concerned that other steps (like adding a 3PID to your account in General settings) may also face this issue.

In any case @nadonomy, we can probably apply the same UX to any other areas facing this as well, so updating designs as you described sounds good to me.

@nadonomy

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Ok, in that case I'll add a comp for how we can visualise this generically in any section in Settings.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Marking blocked for now until we have designs.

@nadonomy

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@jryans I've updated Zeplin here: https://zpl.io/brMdWo3

Screenshot 2019-08-13 at 15 15 28

I'm a little removed from the privacy project while I'm working on other things, so would appreciate any input/to rubber duck any logical dependencies or if you think we should/shouldn't expose changing an identity server in this state, etc.

But, hopefully this is enough to unblock the visual design at least, even if we need to chew the fat on some of the minutiae of what we do/don't expose.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Thanks, I think that's seems like it should work to me. 😁

@turt2live turt2live self-assigned this Aug 16, 2019

@jryans jryans added this to In Progress in Workflow via automation Aug 19, 2019

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 20, 2019

@turt2live turt2live moved this from In Progress to In Review in Workflow Aug 20, 2019

Workflow automation moved this from In Review to In Test Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.