Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline terms agreement on change IS and IM #10539

Closed
dbkr opened this issue Aug 12, 2019 · 6 comments

Comments

@dbkr
Copy link
Member

commented Aug 12, 2019

This
dvvfuOvOVaYFruARsvQBdGzm

@jryans jryans added phase:2 and removed bug p1 phase:1 labels Aug 12, 2019
@turt2live turt2live changed the title Inline terms agreement on change IS Inline terms agreement on change IS and IM Aug 12, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

I've bundled IMs into this because it'll be largely copy/paste code.

@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

This is blocked on a decision for how to move forward when there's no terms available.

image

In the above, the 'no terms' text says continue if you want to, however provides no way to do that. This raises some questions:

  1. Do we even want to allow people to continue?
  2. If we do let them continue, is that okay for GDPR?
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

New design:
image

@turt2live turt2live added this to In Progress in Workflow via automation Aug 14, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

After an epic battle involving me reevaluating my career path, we're changing the design yet again for this. It turns out that our tooltips are non-interactive and popovers don't do what we want. Instead of suffering in silence, we're just going to use dialogs.

New UX (no mockups):

  • User enters a URL into the field
  • User submits form
  • Checking server tooltip
  • Four possible cases:
    1. The settings take effect (service has terms, and they are already signed)
    2. Service has no terms (warning dialog)
    3. Terms agreement dialog (existing)
    4. Connection error tooltip

Reference sample screenshots:
image
image
and above for existing tooltips

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 15, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 15, 2019
@turt2live

This comment has been minimized.

@turt2live turt2live moved this from In Progress to In Review in Workflow Aug 15, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Both parts have landed

@turt2live turt2live closed this Aug 19, 2019
Workflow automation moved this from In Review to In Test Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
3 participants
You can’t perform that action at this time.