Inline terms agreement on change IS and IM

[dbkr]

This

[turt2live]

I've bundled IMs into this because it'll be largely copy/paste code.

[turt2live]

This is blocked on a decision for how to move forward when there's no terms available.

In the above, the 'no terms' text says continue if you want to, however provides no way to do that. This raises some questions:

1. Do we even want to allow people to continue?
2. If we do let them continue, is that okay for GDPR?

[turt2live]

New design:

[turt2live]

After an epic battle involving me reevaluating my career path, we're changing the design yet again for this. It turns out that our tooltips are non-interactive and popovers don't do what we want. Instead of suffering in silence, we're just going to use dialogs.

New UX (no mockups):

• User enters a URL into the field
• User submits form
• Checking server tooltip
• Four possible cases:
  1. The settings take effect (service has terms, and they are already signed)
  2. Service has no terms (warning dialog)
  3. Terms agreement dialog (existing)
  4. Connection error tooltip

Reference sample screenshots:


and above for existing tooltips

[turt2live]

IM: matrix-org/matrix-react-sdk#3316
IS: matrix-org/matrix-react-sdk#3317

[turt2live]

Both parts have landed