Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Riot without an IS, identity requests are sent to server hosting Riot #10540

Closed
jryans opened this issue Aug 12, 2019 · 0 comments · Fixed by matrix-org/matrix-js-sdk#1014

Comments

@jryans
Copy link
Member

commented Aug 12, 2019

When the JS SDK has no IS, idBaseUrl can be "", which means identity requests compose URLs without a scheme or origin, so they default to targeting the server hosting Riot.

We should probably throw an error in the JS SDK if you read idBaseUrl when empty, or something like this.

@jryans jryans self-assigned this Aug 12, 2019
@jryans jryans added this to In Progress in Workflow via automation Aug 12, 2019
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 12, 2019
@jryans jryans assigned dbkr and unassigned jryans Aug 12, 2019
@jryans jryans moved this from In Progress to In Review in Workflow Aug 12, 2019
Workflow automation moved this from In Review to In Test Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.