Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for fallback VOIP should only happen when the user tries to make a call #10546

Closed
turt2live opened this issue Aug 13, 2019 · 1 comment

Comments

@turt2live
Copy link
Member

commented Aug 13, 2019

As currently proposed/defined, the prompt for using a fallback server is done at startup. This is subpar imo for a number of reasons:

  1. There's a number of homeservers out there (including mine) which have not bothered to set up VoIP because there's no need for it. For instance, I don't make calls through Matrix and therefore haven't bothered to set it up. Getting a prompt is just going to be annoying for me.
  2. Some homeservers (including some I run) intentionally have not set up a TURN server largely because of point 1. The users on the homeserver are largely not technologically inclined and do not make calls in the first place - this prompt will be confusing and annoying to them, regardless of the copy used.
  3. It is yet another thing added the onboarding experience. The mobile apps are the worst offenders for this (vector-im/riot-meta#214) and would now have 3 prompts at startup. New users trying to register for the app already feel drained by the time they actually get to send a message - another prompt that won't affect them is likely to be the nail in the coffin.
@jryans jryans self-assigned this Aug 13, 2019
@jryans jryans added this to In Progress in Workflow via automation Aug 13, 2019
@jryans

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

We'll be changing this to happen in context, so I'll assign this and revise the PRs.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 14, 2019
This moves the ICE fallback prompt out of session startup and instead it will
now appear contextually when your either place a call with no ICE server from
the homeserver or a call fails (in either direction).

Fixes vector-im/riot-web#10546
@jryans jryans moved this from In Progress to In Review in Workflow Aug 14, 2019
Workflow automation moved this from In Review to In Test Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.