Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a terms prompt when inviting an email address clears the address picker #10603

Closed
turt2live opened this issue Aug 21, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3414

Comments

@turt2live
Copy link
Member

commented Aug 21, 2019

Enter an email address into the start chat (AddressPickerDialog) dialog without having accepting terms. Before clicking the button, you'll get a terms prompt. After the terms prompt is dealt with your address picker is empty. Likely because the dialog remounted and wiped the old dialog's state.

@turt2live turt2live self-assigned this Sep 10, 2019
@turt2live turt2live added this to In Progress in Workflow via automation Sep 10, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 10, 2019
Fixes vector-im/riot-web#10603

Static dialogs are ones that stay open underneath other dialogs, like the terms of service prompt. This is how user/room settings operate.
@turt2live turt2live moved this from In Progress to In Review in Workflow Sep 10, 2019
Workflow automation moved this from In Review to In Test Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.