Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case of no IS in features that require IS to lookup #10619

Closed
jryans opened this issue Aug 22, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3367

Comments

@jryans
Copy link
Member

commented Aug 22, 2019

Since it's now possible to be disconnected from an identity server entirely (your session has no active identity server), it's unclear how features that require an IS to function should behave.

For the case of the Discovery section in Settings, it's easy enough: you have no IS, so we don't show any 3PIDs to control.

However, there are other IS-using features in Riot, like:

  1. Inviting by 3PID via the address picker

2019-08-23 at 16 02

  1. Inviting by 3PID via /invite bob@bob.com
  2. Checking an email invite in the invite preview bar to ensure the invited email is for the active account (in case you have multiple Matrix accounts in different tabs, etc.) (Extracted feature 3 to #10669.)

For features 1 and 2, I think we need some UX advice from @nadonomy on what they should do (communicate some kind of error to the user, etc.).

For feature 3, I think we are at an earlier stage where @lampholder needs to work out how the product should function for this case.

@nadonomy

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@jryans on these, I just edited these via inspector at runtime, but could we do something along these lines:

1. Inviting via address picker

Screenshot 2019-08-23 at 15 03 48

  • Remove the 'Who would you like to this room?' text as it's redundant
  • Add helper text below the input. Validation should continue to be the closest to the input, so this helper text should live after all the things that relate to input, and before the buttons.

2. Inviting via /invite
Screenshot 2019-08-23 at 14 58 18

  • Display a generic modal when the user completes the action. We should be able to use this in other places too.
  • Note: Note: This screenshot has old, more verbose copy. Best to use:

Use an identity server
Use an identity server to invite by email. Click continue to use the default Identity Server (vector.im) or manage in Settings.

We could keep the copy more generic ('Use an identity server to continue') if we think we'll use this in multiple contexts.

3. Same text, contextual styles

  • Same as 2, I think just displaying the same text (and links) in place should be fine using the contextual styles you screenshotted.
@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Thanks @nadonomy! There's enough work here for features 1 and 2 that it's seems reasonable to consider at least that portion unblocked.

Since the status of feature 3 is less clear, I have broken it out to a separate issue #10669 which is marked blocked for now.

@jryans jryans removed the blocked label Aug 27, 2019
@jryans jryans self-assigned this Aug 28, 2019
@jryans jryans added this to In Progress in Workflow via automation Aug 28, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2019
The subtext here was deemed redundant.

Part of vector-im/riot-web#10619
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2019
This allows those who previously disconnected from an IS to either choose the
default IS or a custom one from Settings via the address picker dialog.

Part of vector-im/riot-web#10619
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2019
The subtext here was deemed redundant.

Part of vector-im/riot-web#10619
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 29, 2019
This allows those who previously disconnected from an IS to either choose the
default IS or a custom one from Settings via the address picker dialog.

Part of vector-im/riot-web#10619
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 30, 2019
This adds a dialog to ask how you want to proceed when trying to invite via
email when there is no IS configured.

Fixes vector-im/riot-web#10619
@jryans jryans moved this from In Progress to In Review in Workflow Aug 30, 2019
Workflow automation moved this from In Review to In Test Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.