Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auth flows so that you default to no IS #10620

Closed
jryans opened this issue Aug 22, 2019 · 2 comments

Comments

@jryans
Copy link
Member

commented Aug 22, 2019

We should change the auth flows so that after registration and login, your client is not connected to any IS by default. Instead, you can choose to connect to one in Settings (and if you do, it is saved to account data and is then used for future sessions).

The only place a default IS should appear after this work is in Settings as the default value for an IS you can choose to connect to.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

After some discussion with @nadonomy, it's a bit less clear whether we want to take this direction. Marking blocked for now.

@jryans jryans added the blocked label Aug 22, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

We've decided not to make this change. You will have a default IS from config and agree to terms in context. As an advanced user, you can also choose to fully disconnect from the IS in Settings.

@jryans jryans closed this Aug 23, 2019
@jryans jryans removed the blocked label Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.