Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline terms agreement in Discovery should still show change and do not use #10635

Closed
jryans opened this issue Aug 23, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3348

Comments

@jryans
Copy link
Member

commented Aug 23, 2019

At the moment, if you have terms with an IS that you have not agreed in the Discovery section, the only presented option is to agree:

2019-08-23 at 15 18

We should also allow:

  • Changing the IS (like you would see when connected to an IS)
  • Setting the IS to nothing even before we've used it (similar to Disconnect, but this needs a different verb, copy in related issue #10636)

Relates to work from #10522
See also #10636

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

We may also need to carefully tweak the "Do not use" behaviour here: at the moment, "Disconnect" attempts to lookup your current state with the IS to helpfully suggest unbinding first, but we can't actually call lookup when there are unagreed terms.

@jryans jryans added the blocked label Aug 23, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

This was actually in the design and I completely forgot to add it (sorry):
image
https://app.zeplin.io/project/5c122fa790c5b4241ffa6be7/screen/5d14ffed0c469a50ec390c47

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

No worries, there are many moving pieces flying about the place... 😅

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

I believe this is now unblocked with the specific copy text (filed in the related #10636).

@jryans jryans removed the blocked label Aug 23, 2019
@turt2live turt2live self-assigned this Aug 26, 2019
@turt2live turt2live added this to In Progress in Workflow via automation Aug 26, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 26, 2019
@turt2live turt2live moved this from In Progress to In Review in Workflow Aug 26, 2019
Workflow automation moved this from In Review to In Test Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.