Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing from one IS to another does not trigger bound 3PID warning #10749

Closed
jryans opened this issue Sep 4, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3394

Comments

@jryans
Copy link
Member

commented Sep 4, 2019

The warning only seems to appear when disconnecting, but should also appear for changing.

@jryans jryans self-assigned this Sep 5, 2019
@jryans jryans added this to In Progress in Workflow via automation Sep 5, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 5, 2019
This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

Fixes vector-im/riot-web#10749
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 5, 2019
This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

Fixes vector-im/riot-web#10749
@jryans jryans moved this from In Progress to In Review in Workflow Sep 5, 2019
Workflow automation moved this from In Review to In Test Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
1 participant
You can’t perform that action at this time.