Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After changing IS back to vector.im the text field isn't cleared and the button remains active #10757

Closed
jryans opened this issue Sep 5, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3398

Comments

@jryans
Copy link
Member

commented Sep 5, 2019

Clicking it again shows the "this IS doesn't have terms" warning again and leaves the textbox/button in populated/active state.

@jryans jryans self-assigned this Sep 6, 2019
@jryans jryans added this to In Progress in Workflow via automation Sep 6, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 6, 2019
This stops setting a value in the IS input on account change. While it may have
been marginally useful if you have the form open and change on a different
device, it also seems to pick up changes on the current device, leading to
strange UX locally.

Fixes vector-im/riot-web#10756
Fixes vector-im/riot-web#10757
@jryans jryans moved this from In Progress to In Review in Workflow Sep 6, 2019
Workflow automation moved this from In Review to In Test Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
1 participant
You can’t perform that action at this time.