Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When publishing a threepid to an IS, if you click 'continue' before clicking the link in your email, we delete your threepid from the HS. #10779

Closed
lampholder opened this issue Sep 6, 2019 · 5 comments

Comments

@lampholder
Copy link
Member

commented Sep 6, 2019

Tested using:

riot.im/develop
the test homeserver andrew spun up
vector.im as the IS

@jryans

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Yes, delete from the HS is indeed the first step we take:

  1. Delete from HS
  2. Trigger email verification
  3. User hopefully verifies email link and presses continue
  4. Adjust discovery status

So, we could delay the delete step to avoid this... but rather than doing that, it would be a lot better to use the "re-add with different bind setting" flow from MSC2229.

At the moment though, MSC2229 work is deferred to phase 2.

If this issue is phase 1, should we try only re-ordering the delete (which will add complexity to Riot) or pull MSC2229 into phase 1?

@jryans

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Ah well, @anoadragon453 went ahead and implemented MSC2229 in Synapse just now... so I guess it's "basically free" to pull into phase 1 now, as clients can choose to use it.

@jryans

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Let's do some technical version of:

  • checking whether you've already clicked the link in the background, or...
  • keep a continue button on screen until you submit it successfully
@jryans

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

We are planning to address through an upcoming MSC, so putting this on hold until we have issues to implement the client version of that work.

@lampholder

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

Closing this in favour of #10839

@lampholder lampholder closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.