Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS with unagreed terms will block you from adding even unshared 3PIDs to your HS #10823

Closed
jryans opened this issue Sep 11, 2019 · 2 comments

Comments

@jryans
Copy link
Member

commented Sep 11, 2019

If you are connected to an IS but have not agreed its terms, this will prevent you from adding a 3PID to your HS account (even when not shared for discovery).

  • We send the IS to the HS for all 3PID adds
  • The HS will use that IS to verify your 3PID ownership
  • v2 IS APIs require a valid IS access token with all terms agreed for these steps to proceed

Riot currently only flags the inline need for terms agreement in the Discovery section, but in reality it's needed for the Account section as well.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

We are planning to address through an upcoming MSC, so putting this on hold until we have issues to implement the client version of that work.

@lampholder

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Closing this in favour of #10839

@lampholder lampholder closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.