Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX regression when trying to invite by email if no IS is configured #10878

Closed
manuroe opened this issue Sep 16, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3449

Comments

@manuroe
Copy link
Member

commented Sep 16, 2019

On matrix.org HS with no IS, I get this screen on https://riot.im/develop:

image

The console says:

Error: "No Identity Server base URL set

#10619 suggested a better UX.

@jryans jryans self-assigned this Sep 17, 2019
@jryans jryans added this to In Progress in Workflow via automation Sep 17, 2019
@jryans jryans added the regression label Sep 17, 2019
@jryans

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

This is a regression introduced by matrix-org/matrix-react-sdk#3408.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 17, 2019
The address picker recently started tracking props and state versions of valid
address types separately
(#3408), where props
represents the maximal set of possible types and the state is the current
available types right now (since it can change while the dialog is open).

For the case where there is no a IS, a regression was introduced by that PR by
mutating the props in place instead returning a modified copy for the state.

Regressed by #3408
Fixes vector-im/riot-web#10878
@jryans jryans moved this from In Progress to In Review in Workflow Sep 17, 2019
Workflow automation moved this from In Review to In Test Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.