Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include ID server or access token when HS supports MSC2290 #10933

Closed
jryans opened this issue Sep 23, 2019 · 0 comments · Fixed by matrix-org/matrix-js-sdk#1041

Comments

@jryans
Copy link
Member

commented Sep 23, 2019

For HSes that support MSC2290 (as indicated by m.separate_add_and_bind: true), we need to remove id_server and id_access_token from all requestToken calls to the homeserver.

This is an important UX step, as otherwise we would try to create a token with the IS, which additionally means present terms to the user for a service we're not actually meant to be using.

@jryans jryans self-assigned this Sep 23, 2019
@jryans jryans added this to In Progress in Workflow via automation Sep 23, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Sep 23, 2019
This removes the IS details (server and access token) from `requestToken` calls
to the HS, as long as the HS supports the new separate add and bind mode. In
this mode, all of the 3PID validation is handled by the HS, so the IS details
are not used.

Fixes vector-im/riot-web#10933
@jryans jryans moved this from In Progress to In Review in Workflow Sep 23, 2019
Workflow automation moved this from In Review to In Test Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
1 participant
You can’t perform that action at this time.