Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful 400 error when adding MSISDN and server doesn’t delegate #10950

Open
jryans opened this issue Sep 24, 2019 · 3 comments

Comments

@jryans
Copy link
Member

commented Sep 24, 2019

If you try to add a MSISDN to your account in Settings, but the HS is not configured to delegate MSISDN handling, Riot does not handle the error very well and presents a 400 error.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2019

This is ideally resolved by a better error code in the spec and / or some way the client to know if HS supports adding MSISDNs.

@rxl881

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

Screenshot 2019-10-11 at 11 52 00

Screenshot 2019-10-11 at 11 51 16

In my opinion it would be good to disable or hide the input in settings if MSISDN registration / MSISDN delegation is disabled (e.g. for all Modular servers, currently).

@jryans

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2019

Right, I think we all agree. The challenge is that at the moment the HS doesn't signal to the client whether it supports adding MSISDNs, so we may need some spec work to add that signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.